Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9118 )
Change subject: InMPALA-4319: remove some deprecated query options ...................................................................... Patch Set 1: (4 comments) Thank you for working on this. http://gerrit.cloudera.org:8080/#/c/9118/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9118/1//COMMIT_MSG@7 PS1, Line 7: InMPALA typo http://gerrit.cloudera.org:8080/#/c/9118/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/9118/1/be/src/service/query-options.h@a54 PS1, Line 54: Should we remove this one here, too (IMPALA-2963)? http://gerrit.cloudera.org:8080/#/c/9118/1/be/src/service/query-options.h@a62 PS1, Line 62: Can you mention all removed options in the commit message? This way the commit will be easier to find in the future. http://gerrit.cloudera.org:8080/#/c/9118/1/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/9118/1/common/thrift/ImpalaInternalService.thrift@101 PS1, Line 101: 9: optional bool allow_unsupported_formats = 0 Should we consider compacting the numeric IDs? My understanding is that we usually don't support mixing different versions of Impala. -- To view, visit http://gerrit.cloudera.org:8080/9118 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e742e9b0eca0e5c81fd71db3122fef31522fcad Gerrit-Change-Number: 9118 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jan 2018 00:35:26 +0000 Gerrit-HasComments: Yes
