Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/9031 )
Change subject: IMPALA-3651: [DOCS] Doc for MURMUR_HASH() function ...................................................................... Patch Set 1: (5 comments) Applied the update. http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9031/1//COMMIT_MSG@7 PS1, Line 7: [DOCS] > Let's include a reference to the code JIRA: Done http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@862 PS1, Line 862: 2.12.0 > rev="IMPALA-3651 2.12.0" Done http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@871 PS1, Line 871: https://en.wikipedia.org/wiki/MurmurHash > Could you add an entry in ../impala_keydefs.ditamap for this wiki page, fol Done http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@878 PS1, Line 878: You might use the return value > Is there some aspect of performance, collisions, or similar that would infl Done http://gerrit.cloudera.org:8080/#/c/9031/1/docs/topics/impala_math_functions.xml@907 PS1, Line 907: relatively low entropy > Is this statement really true for murmur_hash()? For fnv_hash(), the corres Done. Sorry, it's my mistake. -- To view, visit http://gerrit.cloudera.org:8080/9031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I784a5a080d7d13192aac2fca67f841d2d19fc99b Gerrit-Change-Number: 9031 Gerrit-PatchSet: 1 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jan 2018 09:40:34 +0000 Gerrit-HasComments: Yes
