Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9135 )
Change subject: IMPALA-6410: compare_branches: use looser expression ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py File bin/compare_branches.py: http://gerrit.cloudera.org:8080/#/c/9135/1/bin/compare_branches.py@107 PS1, Line 107: for nit: While you're here, should we add "not [for|to] {branch}" instead? -- To view, visit http://gerrit.cloudera.org:8080/9135 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3f75d9e01d2760571547b1a1a5f42bbc8455a05 Gerrit-Change-Number: 9135 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Jan 2018 17:10:58 +0000 Gerrit-HasComments: Yes
