Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8851 )
Change subject: IMPALA-3193: Show table's comment on show tables ...................................................................... Patch Set 8: (4 comments) Applied the update. http://gerrit.cloudera.org:8080/#/c/8851/8/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8851/8/be/src/service/client-request-state.cc@281 PS8, Line 281: } > DCHECK(names.size() == comments.size()); Done http://gerrit.cloudera.org:8080/#/c/8851/8/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/8851/8/common/thrift/Frontend.thrift@95 PS8, Line 95: of table names and a list of optional table comment. : // Table comment is set if the table is loaded, so it will be empty. > "of TTableInfo". I believe that is sufficient, since you already have a des Done http://gerrit.cloudera.org:8080/#/c/8851/8/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/8851/8/fe/src/main/java/org/apache/impala/service/JniCatalog.java@198 PS8, Line 198: tableInfo.setTbl_name(name); > Why not adding the table comments and let the client decide whether they ar Done http://gerrit.cloudera.org:8080/#/c/8851/8/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: http://gerrit.cloudera.org:8080/#/c/8851/8/tests/metadata/test_metadata_query_statements.py@194 PS8, Line 194: result = self.execute_query("show tables in {db} like 'loaded'".format(db=unique_database)) : assert "SHOULD BE SHOWN" in result.data[0] : result = self.execute_query("show tables in {db} like 'not_loaded'".format( : db=unique_database)) : assert "" in result.data[0] : result = self.execute_query("show tables in {db} like 'no_comment'".format( : db=unique_database)) : assert "" in result.data[0] > I'd rather you did a single show tables call in {db} and verify the results Done -- To view, visit http://gerrit.cloudera.org:8080/8851 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44f814af05db6f3c027718ade9f474f8b8153bcd Gerrit-Change-Number: 8851 Gerrit-PatchSet: 8 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Fri, 26 Jan 2018 00:33:01 +0000 Gerrit-HasComments: Yes
