Vuk Ercegovac has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9089 )

Change subject: IMPALA-6215: Removes race when using LibCache.
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9089/7/be/src/runtime/lib-cache.h
File be/src/runtime/lib-cache.h:

http://gerrit.cloudera.org:8080/#/c/9089/7/be/src/runtime/lib-cache.h@83
PS7, Line 83: must held
> garbled.  Maybe: 'handle' must remain in scope while 'path' is used?
whoops, missed a word there. fixed.



--
To view, visit http://gerrit.cloudera.org:8080/9089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9175085201fe8b11424ab8f88d7b992cb7b0daea
Gerrit-Change-Number: 9089
Gerrit-PatchSet: 7
Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Jan 2018 00:06:18 +0000
Gerrit-HasComments: Yes

Reply via email to