Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8707 )
Change subject: IMPALA-4835: Part 2: Allocate scan range buffers upfront ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/8707/19/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/8707/19/be/src/runtime/io/scan-range.cc@129 PS19, Line 129: hit > hits I intended past tense "hit". Reworded to be a little less ambiguous. http://gerrit.cloudera.org:8080/#/c/8707/19/be/src/runtime/io/scan-range.cc@131 PS19, Line 131: if (external_buffer_tag_ != ExternalBufferTag::NO_BUFFER > I think swapping the if and the enclosing for is more clear. Done -- To view, visit http://gerrit.cloudera.org:8080/8707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia243bf8b62feeea602b122e0503ea4ba7d3ee70f Gerrit-Change-Number: 8707 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 30 Jan 2018 19:30:06 +0000 Gerrit-HasComments: Yes
