Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9032 )
Change subject: IMPALA-6219: Use AES-GCM for spill-to-disk encryption ...................................................................... Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9032/9/be/src/util/openssl-util-test.cc File be/src/util/openssl-util-test.cc: http://gerrit.cloudera.org:8080/#/c/9032/9/be/src/util/openssl-util-test.cc@149 PS9, Line 149: // Check if GCM mode > Thank Sailesh for the comments. Even it has been set as GCM mode, it may fa Ah you're right. I got confused by the function name. The comment makes it clearer. -- To view, visit http://gerrit.cloudera.org:8080/9032 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ea87b82a8897ee8bfa187715ac1c52883790d24 Gerrit-Change-Number: 9032 Gerrit-PatchSet: 10 Gerrit-Owner: Xianda Ke <kexia...@gmail.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Xianda Ke <kexia...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 31 Jan 2018 06:43:34 +0000 Gerrit-HasComments: Yes
