Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9165 )
Change subject: IMPALA-6455: unique tmpdirs for test_partition_metadata_compatibility ...................................................................... Patch Set 1: (2 comments) Thanks; this smells right to me. See one minor note below about the configurability of HiveServer2's address. http://gerrit.cloudera.org:8080/#/c/9165/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/9165/1/tests/common/impala_test_suite.py@665 PS1, Line 665: # https://issues.apache.org/jira/browse/MAPREDUCE-6441 is resolved. Consider mentioning that a similar workaround is employed in bin/load-data.py (and maybe doing the same there). http://gerrit.cloudera.org:8080/#/c/9165/1/tests/common/impala_test_suite.py@672 PS1, Line 672: '-u', 'jdbc:hive2://' + pytest.config.option.hive_server2, Should we check that this (pytest.config.option.hive_server2) startswith localhost to apply this hiveconf? For something like the remote cluster tests, this is probably unnecessary and/or harmful. (I have not tested with mapreduce.cluster.local.dir does when the job is remote; I expect that it'll create the dir on the remote HS2, and your rmtree will fail.) -- To view, visit http://gerrit.cloudera.org:8080/9165 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibabff859d19ddbb2a3048ecc02897a611d8ddb20 Gerrit-Change-Number: 9165 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 31 Jan 2018 16:51:41 +0000 Gerrit-HasComments: Yes
