Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9140 )
Change subject: IMPALA-6113: Skip row groups with predicates on NULL columns ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc File be/src/exec/parquet-column-stats.cc: http://gerrit.cloudera.org:8080/#/c/9140/3/be/src/exec/parquet-column-stats.cc@132 PS3, Line 132: bool ColumnStatsBase::ReadNullCountStat(const parquet::ColumnChunk& col_chunk, > Can we use the same pattern as ReadFromThrift() - i.e. return a bool to ind Sure, done. However, in my opinion returning a bool from this function is overkill as the success of the logic can be judged based on the null_count pointer being null or not. For ReadFromThrift it was a bit different as the slot variable was a pre-allocated memory buffer and outside of the function it wasn't possible to decide whether we can use the content of this buffer or not, hence a bool return value was required. Where ReadNullCountStat is invoked, if we check the return value we have a false impression that we can use the pointer (however, if some future modification ruins the content of the function it can happen that we still have a null pointer meanwhile returning true), so we might want to check both the return value and the null_count pointer but then the return value has no point. Could you share your thoughts? http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py File tests/query_test/test_parquet_stats.py: http://gerrit.cloudera.org:8080/#/c/9140/3/tests/query_test/test_parquet_stats.py@49 PS3, Line 49: self.run_test_case('QueryTest/parquet-stats', vector, use_db=unique_database) > Can you move these into parquet-stats.test - I don't think there's a reason Sure. It was suggested by Anuj to move the create statements here. I'll move them back using $DATABASE. -- To view, visit http://gerrit.cloudera.org:8080/9140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I141317af0e0df30da8f220b29b0bfba364f40ddf Gerrit-Change-Number: 9140 Gerrit-PatchSet: 4 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Feb 2018 11:51:02 +0000 Gerrit-HasComments: Yes
