Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9164 )
Change subject: IMPALA-6448: Re-enable kerberized testing with KRPC ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9164/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9164/1//COMMIT_MSG@13 PS1, Line 13: off for the entirety of the process life. This means that we cannot > May help to point out which function this decision is implemented. IIUC, it Yes that's right. I updated the commit message. http://gerrit.cloudera.org:8080/#/c/9164/1/be/src/rpc/rpc-mgr-test.cc File be/src/rpc/rpc-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/9164/1/be/src/rpc/rpc-mgr-test.cc@81 PS1, Line 81: auto cert_flag = : ScopedFlagSetter<string>::Make(&FLAGS_ssl_server_certificate, SERVER_CERT); : auto pkey_flag = : ScopedFlagSetter<string>::Make(&FLAGS_ssl_private_key, PRIVATE_KEY); : auto ca_flag = : ScopedFlagSetter<string>::Make(&FLAGS_ssl_client_ca_certificate, "unknown"); > Is it worth factoring these 3 lines out as a macro and putting them in rpc- That sounds like a good idea. Instead of a macro, I used a scoped class setter to set all TLS flags and changed all the TLS flag setting locations to use that instead. -- To view, visit http://gerrit.cloudera.org:8080/9164 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6412978316de90875c98f8fbe51c8d215c227b18 Gerrit-Change-Number: 9164 Gerrit-PatchSet: 1 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Thu, 01 Feb 2018 20:02:45 +0000 Gerrit-HasComments: Yes
