Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9223 )
Change subject: IMPALA-6392: Consistent explain format for parquet predicate statistics ...................................................................... Patch Set 8: (2 comments) Nice! http://gerrit.cloudera.org:8080/#/c/9223/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/9223/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@523 PS8, Line 523: if (!minMaxOriginalConjuncts_.containsKey(tupleDescriptor)) { Use this pattern for fewer lookups: List l = map.get(key); if (l == null) { l = new List(); map.put(key, l); } l.add(value); http://gerrit.cloudera.org:8080/#/c/9223/8/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1104 PS8, Line 1104: TupleDescriptor tupleDescriptor = entry.getKey(); style: we use these standard abbreviations in many places: tupleDescriptor -> tupleDesc or td expressions -> exprs -- To view, visit http://gerrit.cloudera.org:8080/9223 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d55ab6a1ae551867a9f68b3622844102cc854e Gerrit-Change-Number: 9223 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Feb 2018 00:06:37 +0000 Gerrit-HasComments: Yes
