Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9063 )
Change subject: IMPALA-5801: [draft] Clean up codegen GetType() interface ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/9063/1/be/src/codegen/llvm-codegen.h File be/src/codegen/llvm-codegen.h: http://gerrit.cloudera.org:8080/#/c/9063/1/be/src/codegen/llvm-codegen.h@263 PS1, Line 263: GetType > Nearly all calls to this functions use the ::LLVM_CLASS_NAME constant of st I'm not sure that the templated version would improve readability enough to offset the additional noise in compiler error messages (although I could be wrong :)). http://gerrit.cloudera.org:8080/#/c/9063/1/be/src/codegen/llvm-codegen.h@497 PS1, Line 497: llvm::Type* i8_type() { return GetInternalRepresentation(TYPE_TINYINT); } > Calling GetSlotType() is somewhat shorter, but I can switch to llvm calls i Changing the interface first makes sense, we should switch over the implementations in the final patch though. -- To view, visit http://gerrit.cloudera.org:8080/9063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib146ca21af82023b0b460f813eae3435b4b2eb77 Gerrit-Change-Number: 9063 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Feb 2018 01:17:27 +0000 Gerrit-HasComments: Yes