Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9251 )
Change subject: IMPALA-4475: part 1, reduce size of TExecQueryFInstancesParams ...................................................................... Patch Set 1: yes, that's what the Compact protocol in the change description refers to (as one of the options). that should have been the least invasive yet showed some substantial slow downs in one of the micro benchmarks. needs to be investigated more. I saw the Zlib protocol but opted not to use that (I wanted choice for compression and was unclear how to do this per method without reorganizing the service). I had a prototype for choosing to compress or not based on sizes so I can add that back if needed. Though I am not a fan of adding yet more flags, this one should probably be behind one. fwiw, we do such field-level compression for row-batches. other question I have here is how this will live with krpc and eventual transition to protos. -- To view, visit http://gerrit.cloudera.org:8080/9251 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I195c59efc73e5fd4c310ccfc96b480d2209bde09 Gerrit-Change-Number: 9251 Gerrit-PatchSet: 1 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Feb 2018 05:37:08 +0000 Gerrit-HasComments: No
