Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9202 )
Change subject: IMPALA-6396: Exchange node's memory usage should include its receiver's ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/9202/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9202/2//COMMIT_MSG@16 PS2, Line 16: This makes it : easier to identify the peak memory usage of the receivers : of different exchange nodes in the runtime profile and : query summary. > Yes, they use different variants of the MemTracker constructors. The exchan Ok thanks for the explanation. Could you add that line to the commit message? I was worried about the SortedRunMerger, but I see that's in the DataStreamRecvr. I previously erroneously thought it was part of the exchange node itself. Given that's the case, I don't think it's a critical necessity to track the peak mem usage of the recvr separately. -- To view, visit http://gerrit.cloudera.org:8080/9202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ca3c47d87bfcd221d34565eda1878f3c15d5c45 Gerrit-Change-Number: 9202 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Feb 2018 06:50:15 +0000 Gerrit-HasComments: Yes
