Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/9271 )
Change subject: IMPALA-6497: add "Last row fetched" and AC events ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9271/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9271/4/tests/query_test/test_observability.py@220 PS4, Line 220: line would it make sense to print the whole profile here? that way if we hit a problem we can see which events actually got printed and in which order. same for the assert below this. http://gerrit.cloudera.org:8080/#/c/9271/4/tests/query_test/test_observability.py@234 PS4, Line 234: assert event in runtime_profile maybe print the profile here too -- To view, visit http://gerrit.cloudera.org:8080/9271 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32a707e4660061e75c86ad967f1fac6f6737da7e Gerrit-Change-Number: 9271 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Feb 2018 21:29:15 +0000 Gerrit-HasComments: Yes
