Xinran Tinney has posted comments on this change. ( http://gerrit.cloudera.org:8080/9065 )
Change subject: IMPALA-5440: Add planner tests with extreme statistics values ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/9065/14/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java File fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java: http://gerrit.cloudera.org:8080/#/c/9065/14/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@670 PS14, Line 670: * This function plans the given query and fails if the estimated cardinalities are > This function plans the given query and fails if the estimated cardinalitie Done http://gerrit.cloudera.org:8080/#/c/9065/14/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@695 PS14, Line 695: StringBuilder errorLog = new StringBuilder(); > That's fine. In that case we should remove the function comment that talks Done http://gerrit.cloudera.org:8080/#/c/9065/14/fe/src/test/java/org/apache/impala/planner/PlannerTestBase.java@695 PS14, Line 695: StringBuilder errorLog = new StringBuilder(); > I changed the function testing -1 rows, min = -1, this way, it returns erro Done -- To view, visit http://gerrit.cloudera.org:8080/9065 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86dec47cf1438882cafaec53e97864ccfcdff3cb Gerrit-Change-Number: 9065 Gerrit-PatchSet: 15 Gerrit-Owner: Xinran Tinney <xyutin...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Xinran Tinney <xyutin...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 00:31:23 +0000 Gerrit-HasComments: Yes