Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/9291 )
Change subject: IMPALA-6508: add krpc test flag ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/9291/4/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/9291/4/bin/start-impala-cluster.py@57 PS4, Line 57: krpc KRPC http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/custom_cluster_test_suite.py@138 PS4, Line 138: "--impalad_args=-use_krpc" Not quite following what this translates to ? For now, I have been using --impalad_args="--use_krpc=true". Does this line have similar effect ? http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/skip.py File tests/common/skip.py: http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/skip.py@89 PS4, Line 89: krpc nit: KRPC http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/test_skip.py File tests/common/test_skip.py: http://gerrit.cloudera.org:8080/#/c/9291/4/tests/common/test_skip.py@24 PS4, Line 24: class TestSkipIf(ImpalaTestSuite): Is this test gonna be part of the patch or is it for testing only ? -- To view, visit http://gerrit.cloudera.org:8080/9291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01a5de2afac4a0f43d5fceff283f6108ad6a3ab Gerrit-Change-Number: 9291 Gerrit-PatchSet: 4 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Feb 2018 02:31:55 +0000 Gerrit-HasComments: Yes
