Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf' ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc File be/src/exprs/aggregate-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc@611 PS4, Line 611: src.val != src.val In light of IMPALA-6527 I revisited this code. Is it possible for the compiler to optimize this check away? Should we use std::isnan() instead? http://en.cppreference.com/w/cpp/numeric/math/isnan -- To view, visit http://gerrit.cloudera.org:8080/8854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81 Gerrit-Change-Number: 8854 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Feb 2018 17:09:14 +0000 Gerrit-HasComments: Yes