Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9282 )
Change subject: IMPALA-6116: Bound memory usage of DataStreamSevice's service queue ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/9282/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9282/3//COMMIT_MSG@20 PS3, Line 20: 20 5% http://gerrit.cloudera.org:8080/#/c/9282/3/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/9282/3/be/src/service/data-stream-service.cc@41 PS3, Line 41: DEFINE_string(datastream_service_queue_mem_limit, "5%", queue_limit_msg.c_str()); 5% seems ok to start with. Would be good to do some experiments to get an idea for what typical consumption is. -- To view, visit http://gerrit.cloudera.org:8080/9282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idea4262dfb0e0aa8d58ff6ea6a8aaaa248e880b9 Gerrit-Change-Number: 9282 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Feb 2018 07:21:47 +0000 Gerrit-HasComments: Yes