John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9275 )
Change subject: IMPALA-6499: [docs] Fixed formatting errors in split_part function ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9275/3//COMMIT_MSG@7 PS3, Line 7: docs Uppercase "DOCS" http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml File docs/topics/impala_string_functions.xml: http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1067 PS3, Line 1067: <p> : <b>Return type:</b> This looks like the whole paragraph was reformatted by accident. The <p> line shouldn't be wrapped at the end of another line containing text. Was there any change to the actual text in this paragraph? http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1075 PS3, Line 1075: Remove trailing space. http://gerrit.cloudera.org:8080/#/c/9275/3/docs/topics/impala_string_functions.xml@1129 PS3, Line 1129: value:</p><codeblock><![CDATA[ Unfortunate wrapping suggests Oxygen Author mode has reformatted these lines. The lines should be separated like so (with appropriate indentation for paragraph text and </p> tag, leave <codeblock> left-justified with no indentation: text of paragraph </p> <codeblock><![CDATA[ -- To view, visit http://gerrit.cloudera.org:8080/9275 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7623e32aaf31f21a3be4513f26deb0b789a56b1a Gerrit-Change-Number: 9275 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: John Russell <jruss...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 17 Feb 2018 00:03:20 +0000 Gerrit-HasComments: Yes