Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9359 )
Change subject: KUDU-2004. Undefined behavior in TlsSocket::Writev() ...................................................................... KUDU-2004. Undefined behavior in TlsSocket::Writev() TlsSocket::Writev() was attempting to use the value of nwritten from TlsSocket::Write(), but in the case of an error that value was never set or initialized. A simple check to make sure the result from TlsSocket::Write() wasn't an error was added, otherwise we break out of the write loop to cleanup and return the error (thus skipping the line that uses nwritten) Dist job result from before the fix: http://dist-test.cloudera.org/job?job_id=efan.1496860112.16151 Dist job result from after the fix: http://dist-test.cloudera.org/job?job_id=efan.1497036430.19311 Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Reviewed-on: http://gerrit.cloudera.org:8080/7141 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy <mpe...@apache.org> Reviewed-on: http://gerrit.cloudera.org:8080/9359 Reviewed-by: Sailesh Mukil <sail...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/kudu/security/tls_socket.cc M be/src/kudu/util/net/socket.h 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Sailesh Mukil: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/9359 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-Change-Number: 9359 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
