Zoltan Ivanfi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9358 )
Change subject: IMPALA-6538: Fix read path when Parquet min/max statistics contain NaN ...................................................................... Patch Set 4: Code-Review+1 (1 comment) This workaround in the read path seems to be a good quick-fix, but I think the write path should also have a quick fix to make the written stats independent of the data order, i.e. it should not matter whether a NaN is the first value or not. http://gerrit.cloudera.org:8080/#/c/9358/4/testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test File testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test: http://gerrit.cloudera.org:8080/#/c/9358/4/testdata/workloads/functional-query/queries/QueryTest/parquet-stats.test@494 PS4, Line 494: ---- QUERY This is a good test in general, but it does not specifically test for the fix. Both the read path and the write path can be modified to make this test pass and once we will have fixes in both paths, this test won't notice if one of them has a regression. -- To view, visit http://gerrit.cloudera.org:8080/9358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3897fc1426541239223670812f59e2bed32f455 Gerrit-Change-Number: 9358 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Zoltan Ivanfi <zi+ger...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Feb 2018 15:41:42 +0000 Gerrit-HasComments: Yes
