Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9292 )
Change subject: IMPALA-6269: Expose KRPC metrics on debug webpage ...................................................................... Patch Set 18: Code-Review+2 (3 comments) Thanks for the reviews. PS18 addresses the final comments. Carrying Michael's +2. http://gerrit.cloudera.org:8080/#/c/9292/15/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/9292/15/be/src/rpc/impala-service-pool.cc@254 PS15, Line 254: // TODO: Switch to structured JSON (IMPALA-6545). > Please at least add a TODO and mention the JIRA. Done http://gerrit.cloudera.org:8080/#/c/9292/17/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/9292/17/be/src/rpc/impala-service-pool.cc@281 PS17, Line 281: > nit: unnecessary blank line Done http://gerrit.cloudera.org:8080/#/c/9292/17/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9292/17/be/src/rpc/rpc-mgr.cc@165 PS17, Line 165: if (messenger_.get() == nullptr) return; > Can probably move this to be after line 167 instead given how the order in Done -- To view, visit http://gerrit.cloudera.org:8080/9292 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7af7c1a84a5be82c979ca4ef1edf35167493be3f Gerrit-Change-Number: 9292 Gerrit-PatchSet: 18 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Feb 2018 19:07:12 +0000 Gerrit-HasComments: Yes
