Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9367
Change subject: IMPALA-6543: Limit RowBatch serialization size to INT_MAX ...................................................................... IMPALA-6543: Limit RowBatch serialization size to INT_MAX The serialization format of a row batch relies on tuple offsets. In its current form, the tuple offsets are int32s. This means that it is impossible to generate a valid serialization of a row batch that is larger than INT_MAX. This changes RowBatch::SerializeInternal() to return an error if trying to serialize a row batch larger than INT_MAX. This prevents a DCHECK on debug builds when creating a row larger than 2GB. This also changes the compression logic in RowBatch::Serialize() to avoid a DCHECK if LZ4 will not be able to compress the row batch. Instead, it returns an error. Change-Id: I3b022acdf3bc93912d6d98829b30e44b65890d91 --- M be/src/runtime/row-batch.cc M be/src/runtime/row-batch.h M common/thrift/generate_error_codes.py 3 files changed, 18 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/67/9367/1 -- To view, visit http://gerrit.cloudera.org:8080/9367 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I3b022acdf3bc93912d6d98829b30e44b65890d91 Gerrit-Change-Number: 9367 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
