Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9337 )
Change subject: IMPALA-4874: Increase maximum KRPC message size ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/9337/1/be/src/kudu/rpc/transfer.cc File be/src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/9337/1/be/src/kudu/rpc/transfer.cc@38 PS1, Line 38: INT_MAX > I second Sailesh's recommendation to do Fixed. http://gerrit.cloudera.org:8080/#/c/9337/1/be/src/kudu/rpc/transfer.cc@38 PS1, Line 38: INT_MAX > Actually, the WriteVarint32ToArray takes a uint32_t, so just changing the K This is tracked in KUDU-2305. http://gerrit.cloudera.org:8080/#/c/9337/1/testdata/workloads/functional-query/queries/QueryTest/large_strings.test File testdata/workloads/functional-query/queries/QueryTest/large_strings.test: http://gerrit.cloudera.org:8080/#/c/9337/1/testdata/workloads/functional-query/queries/QueryTest/large_strings.test@220 PS1, Line 220: select cast(fnv_hash(l_comment) as string) as h from tpch_parquet.lineitem union all > I will change this to salt it. Done. -- To view, visit http://gerrit.cloudera.org:8080/9337 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876bba0536e1d85e41eacd9c0aeccfe5c2126e58 Gerrit-Change-Number: 9337 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Feb 2018 21:17:04 +0000 Gerrit-HasComments: Yes
