Nithya Janarthanan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9273 )

Change subject: IMPALA-5139: Update mvn-quiet.sh to print execution content to 
log file
......................................................................


Patch Set 6:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@25
PS5, Line 25: "$IMPALA_MVN_LOGS_DI
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@27
PS5, Line 27: cat << EOF | tee -a "$LOG_FILE"
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@29
PS5, Line 29: Running mvn $IMPALA_MAVEN_OPTIONS $@
            : Directory $(pwd)
            : 
========================================================================
            : EOF
> Sure...will do
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35:   echo "mvn $IMPALA_MAVEN_OPTIONS $@ exited with code $?"
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/5/bin/mvn-quiet.sh@35
PS5, Line 35: ho "mvn $
> Done
Done


http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh
File bin/mvn-quiet.sh:

http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh@34
PS6, Line 34:
> Same as above will remove it before publishing it
Done


http://gerrit.cloudera.org:8080/#/c/9273/6/bin/mvn-quiet.sh@34
PS6, Line 34: if ! mvn $IMPALA_MAVEN_OPTIONS "$@" | tee -a "$LOG_FILE" | grep 
-E -e WARNING -e ERROR -e SUCCESS -e FAILURE -e Test;
> Yep...noticed it....was going to fix it before publishing the review.
Done



--
To view, visit http://gerrit.cloudera.org:8080/9273
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I475b17a4dccfa624dda61402491b461c53473f8b
Gerrit-Change-Number: 9273
Gerrit-PatchSet: 6
Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com>
Gerrit-Reviewer: David Knupp <dkn...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 23:43:37 +0000
Gerrit-HasComments: Yes

Reply via email to