Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9227 )
Change subject: IMPALA-6482: add EXEC_TIME_LIMIT_S option ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc@1855 PS8, Line 1855: // Query was deleted or expired already. > maybe add: "or expired already from a previous expiration event" Done http://gerrit.cloudera.org:8080/#/c/9227/8/be/src/service/impala-server.cc@1894 PS8, Line 1894: queries_by_timestamp_.erase(expiration_event++); > how about That makes sense. Iterators are confusing. I changed this and the other occurrences of the same pattern in this function. -- To view, visit http://gerrit.cloudera.org:8080/9227 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id81772ee223ffb64746e241027a5a734a811e1b8 Gerrit-Change-Number: 9227 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 22 Feb 2018 22:31:25 +0000 Gerrit-HasComments: Yes
