Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/9384/7/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/7/www/rpcz.tmpl@99 PS7, Line 99: <!-- Body content will be filled by DataTables below. I noticed below that the table only gets populated with the first call to refresh. While it will not make a large difference, I wonder if we should go back to rendering the table statically like we did in PS2, and then initialize the DataTable when the document has finished loading, i.e. like so: $(document).ready(function() { table = $('#per_conn_metrics').DataTable({...}); } http://gerrit.cloudera.org:8080/#/c/9384/7/www/rpcz.tmpl@245 PS7, Line 245: table.clear().draw(); Is it necessary to draw the empty table first? I thought we should be able to do table.clear().rows.add(rows).draw(); -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 7 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 01:45:00 +0000 Gerrit-HasComments: Yes