Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9418 )
Change subject: IMPALA-6567: ResetMetadataStmt analysis should not load tables. ...................................................................... Patch Set 2: (1 comment) Thanks for the review. Going to merge this since it badly affects data loading time. http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java File fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/9418/2/fe/src/test/java/org/apache/impala/analysis/StmtMetadataLoaderTest.java@189 PS2, Line 189: testResetMetadataStmts > Just curious, whats the naming convention for frontend unit test names? We We're inconsistent about this. In a recent dev@ thread most people expressed a preference for the standard camel-case naming so for new tests I'm going to try and use that (i.e. start with lower case) -- To view, visit http://gerrit.cloudera.org:8080/9418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7033781ebf27ea53cfd26ff0e4f74d4f242bd1dc Gerrit-Change-Number: 9418 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Comment-Date: Fri, 23 Feb 2018 17:08:40 +0000 Gerrit-HasComments: Yes
