Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/9384 )
Change subject: IMPALA-6347: Monitor queue depth size for outgoing RPCs for Reactor threads ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl File www/rpcz.tmpl: http://gerrit.cloudera.org:8080/#/c/9384/11/www/rpcz.tmpl@231 PS11, Line 231: i = 0; i < json["per_conn_metrics"].length; + I think you could just replace this with return [row["remote_ip"], row["outbound_queue_size"]]; That does all you do in 6 lines in PS12, at the cost of duplicating "row". I think the requirement to keep this in sync with the HTML is fine. We do it everywhere else in this file and making this whole thing totally generic might not be worth the added complexity, given how rarely we update it. -- To view, visit http://gerrit.cloudera.org:8080/9384 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84fea531e98d3e84fcc57bf7533655218bc91f4c Gerrit-Change-Number: 9384 Gerrit-PatchSet: 12 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 06 Mar 2018 19:58:39 +0000 Gerrit-HasComments: Yes
