Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9509 )
Change subject: IMPALA-6573: Create consistent response on column access failures ...................................................................... Patch Set 1: (4 comments) Fixed. http://gerrit.cloudera.org:8080/#/c/9509/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9509/1//COMMIT_MSG@11 PS1, Line 11: statement. > It's good to give some examples on where the inconsistencies are. Copied the one from the Jira. http://gerrit.cloudera.org:8080/#/c/9509/1/fe/src/main/java/org/apache/impala/authorization/Authorizeable.java File fe/src/main/java/org/apache/impala/authorization/Authorizeable.java: http://gerrit.cloudera.org:8080/#/c/9509/1/fe/src/main/java/org/apache/impala/authorization/Authorizeable.java@47 PS1, Line 47: // Flag for controlling whether last node in the path is visible. > Why is this not private? Done http://gerrit.cloudera.org:8080/#/c/9509/1/fe/src/main/java/org/apache/impala/authorization/AuthorizeableColumn.java File fe/src/main/java/org/apache/impala/authorization/AuthorizeableColumn.java: http://gerrit.cloudera.org:8080/#/c/9509/1/fe/src/main/java/org/apache/impala/authorization/AuthorizeableColumn.java@52 PS1, Line 52: > Remove extra new line. Done http://gerrit.cloudera.org:8080/#/c/9509/1/fe/src/main/java/org/apache/impala/authorization/AuthorizeableColumn.java@62 PS1, Line 62: if (isLastNodeVisible()) { > By looking at this implementation, last node is always the column. Isn't it It seems like it should also apply to tables, but I've be unable so far to find a specific reproducible scenario. -- To view, visit http://gerrit.cloudera.org:8080/9509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9676a21a171862bb1f664e82d0a7d1db0d36462a Gerrit-Change-Number: 9509 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Wed, 07 Mar 2018 16:55:26 +0000 Gerrit-HasComments: Yes
