Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9500 )
Change subject: IMPALA-6592: add test for invalid parquet codecs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/9500/2/be/src/exec/parquet-common.cc File be/src/exec/parquet-common.cc: http://gerrit.cloudera.org:8080/#/c/9500/2/be/src/exec/parquet-common.cc@24 PS2, Line 24: static > Nit: namespace-scoped const variables are implicitly have internal linkage Done http://gerrit.cloudera.org:8080/#/c/9500/2/be/src/exec/parquet-common.cc@45 PS2, Line 45: sizeof(INTERNAL_TO_PARQUET_TYPES) / sizeof(INTERNAL_TO_PARQUET_TYPES[0]) > Nit: maybe you could use std::array instead. >From what I can tell, it's not currently possible to create a std::array >without specifying the size directly. There's a proposal for make_array but it >doesn't look like it's standardised. I could hard-code the size, but that >overall doesn't seem to result in a simpler solution. -- To view, visit http://gerrit.cloudera.org:8080/9500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1502ea7b7f39aa09f0ed2677e84219b37c64c416 Gerrit-Change-Number: 9500 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 00:24:39 +0000 Gerrit-HasComments: Yes
