Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/9537 )
Change subject: IMPALA-6615: CTE query in Impala shell does not show query web links ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9537/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/9537/1/shell/impala_shell.py@1131 PS1, Line 1131: return self._execute_stmt(query, is_dml=is_dml, print_web_link=is_dml) > My guess is that not every query containing a WITH clause is DML, and if no The WITH clause is only allowed for query statements like SELECT and UNION or for DML like INSERT/UPDATE, but nothing else, so I think the right behavior is print_web_links=True. See uses of opt_with_clause in sql-parser.cup -- To view, visit http://gerrit.cloudera.org:8080/9537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3352406e3b048be395a20405c8e6b911e663164 Gerrit-Change-Number: 9537 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 07:24:02 +0000 Gerrit-HasComments: Yes
