Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9538 )
Change subject: IMPALA-6602: fixes flaky expiration test ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/9538/5/tests/custom_cluster/test_query_expiration.py File tests/custom_cluster/test_query_expiration.py: http://gerrit.cloudera.org:8080/#/c/9538/5/tests/custom_cluster/test_query_expiration.py@179 PS5, Line 179: None > what if python is descheduled in this window? Shouldn't we make sure we do if python is descheduled, the expected state may exist but we could skip it either due to expiration or a state switch. this could be tightened with a do-while. I agree that we can see if this happens in practice. -- To view, visit http://gerrit.cloudera.org:8080/9538 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aabed87d84d5cfd8078cc6c39df48e22ff30afc Gerrit-Change-Number: 9538 Gerrit-PatchSet: 5 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 08 Mar 2018 17:35:36 +0000 Gerrit-HasComments: Yes
