Alex Behm has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/9555 )

Change subject: IMPALA-6227: more logging in test_admission_controller
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py
File tests/custom_cluster/test_admission_controller.py:

http://gerrit.cloudera.org:8080/#/c/9555/1/tests/custom_cluster/test_admission_controller.py@545
PS1, Line 545:       LOG.debug("DeltaSum=%s Deltas=%s (Expected=%s for 
metrics=%s)",\
> I thought that maybe it would be too chatty in this loop, but I guess we're
Up to you to decide, just making sure you didn't forget it. If you omitted on 
purpose, that's totally fine.



--
To view, visit http://gerrit.cloudera.org:8080/9555
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb58a9be4a5d023c1ee3fd76e5992dfba03188c
Gerrit-Change-Number: 9555
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 21:47:20 +0000
Gerrit-HasComments: Yes

Reply via email to