Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9484 )
Change subject: IMPALA-6551: Change Kudu TPCDS and TPCH columns to DECIMAL ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9484/3/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test: http://gerrit.cloudera.org:8080/#/c/9484/3/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test@339 PS3, Line 339: kudu predicates: l_shipdate < '1995-01-01', l_shipdate >= '1994-01-01' Does the Kudu Java API support pushing predicates on DECIMAL columns? The predicates listed under "Kudu predicate" are pushed down into Kudu, reducing the number of rows Kudu has to return to Impala for the scan, where the ones listed under "predicates" are evaluated on the Impala side. Look at KuduScanNode.java and tryConvertBinaryKuduPredicate(), can we add DECIMAL to the switch there? Otherwise, we're missing an opportunity to improve perf in situations like this. I also happened to notice a bug while looking through KuduScanNode.java, filed: IMPALA-6635 -- To view, visit http://gerrit.cloudera.org:8080/9484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7e4464dc6705cadd610a82c459390a9c0dfe4f Gerrit-Change-Number: 9484 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Mar 2018 20:49:34 +0000 Gerrit-HasComments: Yes
