Nithya Janarthanan has posted comments on this change. ( http://gerrit.cloudera.org:8080/9494 )
Change subject: IMPALA-5886 & IMPALA-4812 Update run-tests.py to handle exit_code 5 ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py File tests/run-tests.py: http://gerrit.cloudera.org:8080/#/c/9494/11/tests/run-tests.py@112 PS11, Line 112: len(testcounterplugin.tests_executed) <= 0 > I think this comment was missed from before as well. I don't thinks len(tes Hi David, I think the current placement of this logic is fine because we are handling the non-zero exit code of 5 inside the test_executor. Lets say for example pytest.main gets invoked for "serially" and there were no tests to run, it would default the exit_code to 0 and then after that when parallel gets called and there were tests to execute and they pass then the exit_code would be 0 and 1 if they fail, While before for the same sequence of events RC would be a 5 and 0 or 5 and 1 , but now it would be 0 or 1. So I don't think we need to move this logic to be inside main So going forward systest will exit(1) only when the tests have genuinely failed and not when no tests were collected if exit_code == EXIT_NOTESTSCOLLECTED: if len(testcounterplugin.tests_executed) <= 0 : exit_code = 0 else: exit_code = 1 This would take care of setting the exit_code accordingly thereby avoiding run-tests exiting because there was a pytest RC of 5 (no tests collected) -- To view, visit http://gerrit.cloudera.org:8080/9494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If82f974cc2d1e917464d4053563eaf4afc559150 Gerrit-Change-Number: 9494 Gerrit-PatchSet: 11 Gerrit-Owner: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Comment-Date: Sat, 10 Mar 2018 14:18:41 +0000 Gerrit-HasComments: Yes
