Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9562 )
Change subject: IMPALA-6576: Add metrics for data stream service memory usage ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/service/data-stream-service.cc File be/src/service/data-stream-service.cc: http://gerrit.cloudera.org:8080/#/c/9562/3/be/src/service/data-stream-service.cc@58 PS3, Line 58: InitMetrics I think InitMetrics() is misleading - the name is too similar to other functions that do some kind of global initialization. Maybe something like MemTrackerMetric::CreateMetrics() so it sounds more like a constructor/factory method. -- To view, visit http://gerrit.cloudera.org:8080/9562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5033b8dfda0b23d4230535ba13c3e050a35d01a3 Gerrit-Change-Number: 9562 Gerrit-PatchSet: 3 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 19:07:22 +0000 Gerrit-HasComments: Yes
