Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9590 )
Change subject: IMPALA-6498: test_query_profile_thrift_timestamps causes following tests to fail. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/9590/3/tests/query_test/test_observability.py@198 PS3, Line 198: Moving this test to its own suite (IMPALA-6498). This test case forces Unregistration : # of the query, so that we force computation of query end time, which shows up as : # a non-empty 'End Time' in the profile. We use self.client.close() since the : # Beeswax client does not have a cencellation interface. self.client cannot be used : # after close(), so if new test cases are added to this suite, the test cases must be : # executed before this one. Always better to keep comments brief, if possible. I think all of this can be simplified to something like: "This test needs to call self.client.close() to force computation of query end time, so it has to be in its own suite (IMPALA-6498)." -- To view, visit http://gerrit.cloudera.org:8080/9590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I287a05f3c90b1a71a5b7ee0f5c06a8840ebac4c9 Gerrit-Change-Number: 9590 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 12 Mar 2018 22:22:44 +0000 Gerrit-HasComments: Yes
