Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9556 )
Change subject: IMPALA-6589: remove invalid DCHECK in parquet reader ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/9556/2/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/9556/2/be/src/exec/parquet-column-readers.cc@1207 PS2, Line 1207: rep_level_ = rep_levels_.ReadLevel(); > Can you also add a similar check for the repetition level? Done http://gerrit.cloudera.org:8080/#/c/9556/2/testdata/workloads/functional-query/queries/QueryTest/parquet-num-values-def-levels-mismatch.test File testdata/workloads/functional-query/queries/QueryTest/parquet-num-values-def-levels-mismatch.test: http://gerrit.cloudera.org:8080/#/c/9556/2/testdata/workloads/functional-query/queries/QueryTest/parquet-num-values-def-levels-mismatch.test@7 PS2, Line 7: > nit: unnecessary line Done http://gerrit.cloudera.org:8080/#/c/9556/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/9556/2/tests/query_test/test_scanners.py@433 PS2, Line 433: > nit: unnecessary line Done -- To view, visit http://gerrit.cloudera.org:8080/9556 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd6e09f8c8cca8991be5b5b379f6420adaa97daa Gerrit-Change-Number: 9556 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 13 Mar 2018 00:00:37 +0000 Gerrit-HasComments: Yes
