Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9420 )
Change subject: IMPALA-3866: Improve error reporting for scratch write errors ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/9420/10/be/src/runtime/io/disk-io-mgr.cc File be/src/runtime/io/disk-io-mgr.cc: http://gerrit.cloudera.org:8080/#/c/9420/10/be/src/runtime/io/disk-io-mgr.cc@1098 PS10, Line 1098: if (ret_status.ok() && !close_status.ok()) ret_status = close_status; > Hmm. Actually I think there was a pre-existing bug here. We should close fd Nice catch! Done Note, that I considered close() also to be fault injected, but then for testing I would have needed a way to make both fdopen() and close() fail but the current implementation of the fault injection can handle only one of them. Could have implemented a way to handle multiple failures as well but found that an overkill comparing to the logic this is meant to cover. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/9420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5aa7b424209b1a5ef8dc7d04c5ba58788e91aad7 Gerrit-Change-Number: 9420 Gerrit-PatchSet: 12 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Mar 2018 11:29:10 +0000 Gerrit-HasComments: Yes