Pranay Singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/9614 )
Change subject: DRAFT IMPALA-5973: Provide query plan in JSON format. ...................................................................... Patch Set 1: > - High-level comment: It seems kind of redundant that we build the > explain string and Map at the same time for every getExplainString*(). > Maybe we should have an intermediate state that we can convert to > both text-plan and JSON depending on the caller. Seems like Map > would be the obvious choice (guava has helper methods to build the > explain string from Map) and obviously we can build a JSON string. > > - Please add a web endpoint for the json profile (something like > query_profile?json) to make it easy to consume and write e-e tests. > > Alex, does the approach sound ok, or do you think it can be done in > any better way? Forgot to mention that String will be removed later, I have only added the new code and not removed the old code for verification purpose. Since this is the draft change I'll do the cleanup if the approach is fine. -- To view, visit http://gerrit.cloudera.org:8080/9614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7429ac1e93a9c524233383cafd387056fcf2542d Gerrit-Change-Number: 9614 Gerrit-PatchSet: 1 Gerrit-Owner: Pranay Singh Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Comment-Date: Wed, 14 Mar 2018 16:35:51 +0000 Gerrit-HasComments: No
