Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/9589 )
Change subject: IMPALA-6643: Add REFRESH METADATA fine-grained privilege ...................................................................... Patch Set 8: (4 comments) The patch looks good to me. Just have a few suggestions. http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@11 PS8, Line 11: Also please mention what was the requirement before this patch. http://gerrit.cloudera.org:8080/#/c/9589/8//COMMIT_MSG@15 PS8, Line 15: REFRESH METADATA Just thinking out loud, should we rename it to RELOAD METADATA? From a user perspective, I think it would be confusing to say "a REFRESH METADATA privilege is required to run INVALIDATE METADATA"? What do you think? May be others have a different preference. http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java File fe/src/main/java/org/apache/impala/authorization/Privilege.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/main/java/org/apache/impala/authorization/Privilege.java@54 PS8, Line 54: public enum SentryAction implements Action { Just to be sure, these Impala specific privilege grants to groups are ignored by Hive right? http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/9589/8/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@249 PS8, Line 249: roleName = "refresh_functional_alltypesagg"; I think you could keep a single role (say "refresh_metadata_role") and keep doing grantRolePrivilege() on that right? I think multiple createRole() calls are redundant if you are not switching between them, no? I see the pattern in rest of the test too, but wondering if it is needed. -- To view, visit http://gerrit.cloudera.org:8080/9589 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c3c5a51fe493d39fd719c7a388d4d5760049ce4 Gerrit-Change-Number: 9589 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 02:26:49 +0000 Gerrit-HasComments: Yes
