Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/9626 )
Change subject: IMPALA-6488: removes use-after-free bug in lib_cache ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/9626/4/be/src/runtime/lib-cache.h File be/src/runtime/lib-cache.h: http://gerrit.cloudera.org:8080/#/c/9626/4/be/src/runtime/lib-cache.h@156 PS4, Line 156: loading_status > This comment still seems inaccurate since this routine doesn't use loading_ yes, its too specific to how its used. trimmed down and added a todo to clean this up... http://gerrit.cloudera.org:8080/#/c/9626/4/be/src/runtime/lib-cache.cc File be/src/runtime/lib-cache.cc: http://gerrit.cloudera.org:8080/#/c/9626/4/be/src/runtime/lib-cache.cc@325 PS4, Line 325: // other > newline glitch Done -- To view, visit http://gerrit.cloudera.org:8080/9626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f178a2114cb3969dbb920949ddff4e8220b742e Gerrit-Change-Number: 9626 Gerrit-PatchSet: 4 Gerrit-Owner: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 04:06:26 +0000 Gerrit-HasComments: Yes
