Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9656 )
Change subject: IMPALA-6338: Ensure successfully completed queries have full profile ...................................................................... Patch Set 1: > There are some additional cases in ScannerContext and HdfsScanner > that check ScannerContext::is_cancelled(), which checks > RuntimeState::is_cancelled() but does not return CANCELLED_INTERNAL. > It looks like the data stream code may also have a similar pattern. Good point. Fixing that will make this patch much messier, so I'm not really sure its the right approach anymore. -- To view, visit http://gerrit.cloudera.org:8080/9656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97b031548c64ac16d7e2a09b38baac2d30ac3340 Gerrit-Change-Number: 9656 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Mar 2018 20:10:35 +0000 Gerrit-HasComments: No
