Adam Holley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9619 )
Change subject: IMPALA-5695: restart_first_impalad() does not start impalad ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: http://gerrit.cloudera.org:8080/#/c/9619/1/tests/authorization/test_grant_revoke.py@80 PS1, Line 80: IMPALA_HOME = os.environ['IMPALA_HOME'] : IMPALAD_PATH = os.path.join(IMPALA_HOME, : 'bin/start-impalad.sh --server_name=server1') > The restart method in impala_cluster.py seems to be extracting this path fr The issue is that impalad.restart() remains broken. I think the proper fix is to modify the Process class in tests/common/impala_cluster.py to get and store the environment variables used for the process, and then update exec_process_async so that is can accept environment variables used in Popen. That way, any process we restart should have the same environment as opposed to just going off of the command line. -- To view, visit http://gerrit.cloudera.org:8080/9619 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30a5c25e132deebb9731891364196af31e57d875 Gerrit-Change-Number: 9619 Gerrit-PatchSet: 1 Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Adam Holley <g...@holleyism.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Fri, 16 Mar 2018 02:10:03 +0000 Gerrit-HasComments: Yes
