Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/9506 )
Change subject: IMPALA-6610: Improve LDAP auth fail warning message in impala-shell ...................................................................... Patch Set 10: > Patch Set 10: > > Only the echo command is detected for the following reasons: > a.echo command is the most convenient, safe, direct, and most often used. > b.The use of a script is not conducive to security protection, and it is not > easy to detect what statement caused the line break and give a corresponding > solution. If we're allowing any kind of command to be passed to the shell, then we should make sure to catch the error for any output from that command. If there's an error in a user supplied script, it doesn't matter what line in the script caused the error. As the shell, it's our job to just look at the output of that script/command and say that we detected an error, which in this case is a newline char at the end of the output. The script/command is under the control of the user and the user should make the necessary fixes if there's a bug in it. Your solution is right, but I think we shouldn't limit the fix only for "echo" commands. So a slight tweak should fix that. -- To view, visit http://gerrit.cloudera.org:8080/9506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie570166aea62af223905b7f0124e9efb15a88ac7 Gerrit-Change-Number: 9506 Gerrit-PatchSet: 10 Gerrit-Owner: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Donghui Xu <xu.dong...@zte.com.cn> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 20 Mar 2018 02:14:20 +0000 Gerrit-HasComments: No
