Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/9525 )
Change subject: IMPALA-6389: Make '\0' delimited text files work ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.h File be/src/exec/delimited-text-parser.h: http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.h@174 PS3, Line 174: field_delim_ != tuple_delim_ is it allowed to have field_delim_ same as tuple_delim_? what's the behavior in that case? looking at the callsites, I don't see how we ever add new columns in that case. and do we test it? http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.h@175 PS3, Line 175: ) this would be a little easier to read without the extraneous parens around the whole thing (I kept looking to see which clauses were grouped only to find it covers the entire thing). http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.cc File be/src/exec/delimited-text-parser.cc: http://gerrit.cloudera.org:8080/#/c/9525/3/be/src/exec/delimited-text-parser.cc@182 PS3, Line 182: if (DELIMITED_TUPLES) unfinished_tuple_ = false; can we even get here if !DELIMITED_TUPLES? If not, maybe DCHECK(DELIMINTED_TUPLES) on line 170 (and revert this if-stmt). -- To view, visit http://gerrit.cloudera.org:8080/9525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b6f38cbe3f1036f60efd31a31d82d0cd8f3d2a8 Gerrit-Change-Number: 9525 Gerrit-PatchSet: 3 Gerrit-Owner: Zach Amsden <zams...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zach Amsden <zams...@cloudera.com> Gerrit-Comment-Date: Wed, 21 Mar 2018 16:16:21 +0000 Gerrit-HasComments: Yes
