David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/9758 )
Change subject: IMPALA-6715,IMPALA-6736: fix stress TPC workload selection ...................................................................... Patch Set 4: (2 comments) Feel free to commit http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/9758/4//COMMIT_MSG@37 PS4, Line 37: - While testing on hardware clusters down stream, I noticed IMPALA-6736: Nit: since you've set up IMPALA-6715 as a "sub-header" of sorts, for symmetry, maybe do the same with IMPALA-6736. http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py File tests/stress/concurrent_select.py: http://gerrit.cloudera.org:8080/#/c/9758/4/tests/stress/concurrent_select.py@2071 PS4, Line 2071: Filtering non-spilling query due to mem ratio option Nt: "Filtering non-spilling query that exceeds mem ratio option" -- To view, visit http://gerrit.cloudera.org:8080/9758 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e26b64d38aa8d63a176daf95c4ac5dee89508da Gerrit-Change-Number: 9758 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Nithya Janarthanan <njanartha...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Mon, 26 Mar 2018 18:25:08 +0000 Gerrit-HasComments: Yes