Hello Thomas Tauber-Marshall, Tim Armstrong, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9793 to look at the new patch set (#5). Change subject: IMPALA-5384, part 1: introduce InsertExecState ...................................................................... IMPALA-5384, part 1: introduce InsertExecState This change is based on a patch by Marcel Kornacker. Move data structures that collect INSERT operation stats from the RuntimeState and Coordinator into a new InsertExecState class, which has it's own lock. This removes a dependency on the coordinator's lock, which will allow further coordinator locking cleanup in the next patch. Change-Id: Id4c025917620a7bff2acbeb46464f107ab4b7565 --- M be/src/benchmarks/expr-benchmark.cc M be/src/exec/catalog-op-executor.cc M be/src/exec/data-sink.cc M be/src/exec/data-sink.h M be/src/exec/hbase-table-sink.cc M be/src/exec/hdfs-table-sink.cc M be/src/exec/kudu-table-sink.cc M be/src/exec/plan-root-sink.cc M be/src/runtime/CMakeLists.txt M be/src/runtime/coordinator-backend-state.cc M be/src/runtime/coordinator-backend-state.h M be/src/runtime/coordinator.cc M be/src/runtime/coordinator.h A be/src/runtime/dml-exec-state.cc A be/src/runtime/dml-exec-state.h M be/src/runtime/query-state.cc M be/src/runtime/runtime-filter-bank.cc M be/src/runtime/runtime-state.h M be/src/service/client-request-state.cc M be/src/service/client-request-state.h M be/src/service/impala-beeswax-server.cc M be/src/service/impala-hs2-server.cc M be/src/service/impala-http-handler.cc M be/src/service/impala-server.cc M be/src/service/impala-server.h M be/src/testutil/in-process-servers.cc 26 files changed, 738 insertions(+), 584 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/93/9793/5 -- To view, visit http://gerrit.cloudera.org:8080/9793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: Id4c025917620a7bff2acbeb46464f107ab4b7565 Gerrit-Change-Number: 9793 Gerrit-PatchSet: 5 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>